fix: add missing bundle and watch:bundle tasks to root turbo.json #6433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6432 - Windows debugging issue where VSCode debug configuration failed because the root turbo.json was missing the bundle and watch:bundle task definitions that are required by the debug tasks. The issue occurred because: - VSCode debug configuration runs the default build task (watch) - The watch task depends on watch:bundle via turbo - Root turbo.json was missing bundle and watch:bundle task definitions - This caused "Cannot find module extension.js" error on Windows Changes: - Added bundle task with outputs configuration - Added watch:bundle task with cache disabled - Both tasks now properly delegate to workspace-specific implementations
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| "inputs": ["src/**", "package.json", "tsconfig.json", "tsup.config.ts", "vite.config.ts"] | ||
| }, | ||
| "bundle": { | ||
| "outputs": ["dist/**", "src/dist/**"] |
Contributor
Author
There was a problem hiding this comment.
The bundle task is missing inputs configuration. Should this include the same inputs as the build task (src/**, package.json, tsconfig.json, etc.) to ensure proper cache invalidation when source files change?
| }, | ||
| "bundle": { | ||
| "outputs": ["dist/**", "src/dist/**"] | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Is this intentional that the bundle task configuration is minimal compared to other tasks? For consistency, could it follow the same pattern as the build task with comprehensive inputs configuration?
dosubot
bot
added
size:XS
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
Closing, can't repro |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6432 - Windows debugging issue where VSCode debug configuration failed because the root turbo.json was missing the bundle and watch:bundle task definitions.
Problem
Users on Windows were unable to debug the extension in VSCode because:
Solution
Added the missing task definitions to root turbo.json:
bundletask with proper outputs configurationwatch:bundletask with cache disabledTesting
npx turbo bundleworks correctlynpx turbo watch:bundle --dry-runrecognizes the taskThis fix ensures that the VSCode debug configuration will work properly on Windows by making sure all required turbo tasks are defined at the root level.
Important
Adds missing
bundleandwatch:bundletasks toturbo.jsonto fix Windows VSCode debugging issue.bundleandwatch:bundletasks toturbo.jsonto fix Windows VSCode debugging issue.bundletask includes outputs configuration fordist/**andsrc/dist/**.watch:bundletask has caching disabled.npx turbo bundleandnpx turbo watch:bundle --dry-runwork correctly.extension.jsis generated insrc/dist/.This description was created by
for fe87e25. You can customize this summary. It will automatically update as commits are pushed.